RFR: jpkg contents/show commands
paul.sandoz at oracle.com
Mon May 21 07:29:12 PDT 2012
On May 17, 2012, at 7:04 PM, Chris Hegarty wrote:
> This change adds two new commands to the packaging tool. 'jpkg show' and 'jpkg contents', which came up on this list a few weeks ago.
You may want to update the JavaDoc on the Packager class.
> Also, included is various cleanup and restructuring, especially to ModuleFile, to put in place a structure to more easily support new compression algorithms. Specifically LZMA. I have a prototype from last year I need to rebase.
> For now, 'contents' and 'show' are only added jpkg, but I could see that these may be useful before installing a module into the module library, so could be applicable to the jmod command also? Or just jmod?
Is "jpgk show <mf>" the equivalent of "jmod ls <midq> -v" for a module id query that matches one module?
Seems useful to list the contents of a module installed to a library, but i dunno if it is quite the same thing as listing the contents of the module itself.
A useful addition, not suggesting for this patch, is the ability to extract out jar/class files from a jmod package or a module installed into a library.
> If these new commands are to stay in jpkg long term we should probably change the command that builds the jmod/deb files to create/build, so 'jpkg create ... jmod'.
What about for modular jar files?
> Two specific implementation changes to draw attention to in the webrev:
> 1) ModuleFile.java (L535 new file). Resources were never being
> deflated in the module library. They are now.
> 2) Sean,
> Can you verify the changes to changes to Singer and
> ModuleFile.SignatureSection? All jigsaw signing related tests pass.
More information about the jigsaw-dev