RFR: Try to install already installed jmod/modular jar issue
mandy.chung at oracle.com
Wed May 30 10:54:17 PDT 2012
On 5/29/2012 1:45 PM, Chris Hegarty wrote:
> Trivial issue that crept in whereby if you try to install an already
> installed module it will actually remove it!
> If a module is already installed ( or there is a view or alias with a
> similar name ) the addition to the module directory will fail. The
> error handling code incorrectly assumes that the requested module
> should be removed.
> Trivial change to only attempt removal after the addition to the
> module directory has succeeded, i.e. only if there has been a change
> to the actual library or meta data.
Thanks for catching this issue and adding a test case is good.
Looks fine to me. Nit: SimpleLibrary.java L1163 - missing space before '='.
More information about the jigsaw-dev