Review request for JDK-8141338: Move jdk.internal.dynalink package to jdk.dynalink
sundararajan.athijegannathan at oracle.com
Mon Nov 23 15:42:17 UTC 2015
But, in addition to providing service, jdk.scripting.nashorn module also
"exports" nashorn specific APIs in jdk.nashorn.api.* packages.
On 11/23/2015 9:10 PM, Alan Bateman wrote:
> On 23/11/2015 15:27, Attila Szegedi wrote:
>> I integrated the changes Mandy suggested; please review these (build
>> related) changes:
>> jdk9 top level:
>> For the sake of completeness, the jdk/nashorn changes are here:
>> <http://cr.openjdk.java.net/~attila/8141338/webrev.jdk9> but they
>> have already been reviewed by Hannes and Sundar; only the above two
>> (jdk9 and jdk9/jdk) have been modified compared to the original
>> review request.
>> Sundar was kind enough to verify that JDK9 builds fine with these
> The jdk repo looks okay (just had to change your link to find it :-)
> In the top-level repo then you've moved jdk.scripting.nashorn from
> PROVIDER_MODULES to MAIN_MODULES. The reason that we've had it in
> PROVIDER_MODULES is because we treat it as a service provider module
> (it provides an implementation of javax.script.ScriptEngineFactory).
More information about the jigsaw-dev