RFR 8135972: Implement new tests for native libjimage library
sergei.pikalev at oracle.com
Wed Nov 25 05:02:30 UTC 2015
I've attached the diff with minor changes:
* multipleOpenTest - check on second call of JIMAGE_Open
* removed corrupted data files from patch and create them in @BeforeTest
Should I create new webrev or could I contact Jim or Jean-Francois directly?
Answers on your question:
Yes, the tests could be used in jdk9/dev as well with minor tuning.
On 24.11.2015 11:29, Alan Bateman wrote:
> On 24/11/2015 00:37, Sergei Pikalev wrote:
>> Hi All,
>> There are a minimal set of passing cleanly tests which does not explore
>> bad values touching memory addresses.
>> Please review.
> I assume Jim or Jean-Francois will sponsor this for you. Is
> JImagePackageToModuleTest the only test that is unique to jake? I'm
> just wondering if we can get these tests into via jdk9/dev.
> One thing that isn't clear to me is the multipleOpenTest, I would have
> expected a second call to JIMAGE_Open to return a unique handle.
> A small comment on JImageOpenCloseTest - I assume this should create
> the 0-length or bad-magic jimage file rather than checking in binary
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 22179 bytes
Desc: not available
More information about the jigsaw-dev