jmx-dev RFR 7199353: Allow ConstructorProperties annotation from any package

Mandy Chung mandy.chung at
Mon Oct 19 23:55:05 UTC 2015

> On Oct 16, 2015, at 5:04 AM, Jaroslav Bachorik <jaroslav.bachorik at> wrote:
> On 15.10.2015 21:32, Alan Bateman wrote:
>> On 15/10/2015 16:55, Jaroslav Bachorik wrote:
>>> Any objections to changing the annotation name to @ConstructorMapping
>>> to make it better distinguishable from
>>> @java.beans.ConstructorProperties ?
>> Not from me. Do you mind updating the webrev so that we can see the
>> updated javadoc?
> I have decided for @ConstructorParameters - it is rather close to the original @ConstructorProperties and corresponds to the annotation purpose.
> I tried to address all the comments gathered in this review.
> The updated webrev is

I like the new name.  The change looks good except minor things in

 61  * and {@code} 
- package name needs mixup.

 74     */
- formatting nit - need one more space

> The issue number had to be changed due to unlucky escape of the fix in progress into the public repository (which was immediately backed out but the original issue was 'spent').
> Though the issue title still contains "ConstructorProperties" - I will change it to "ConstructorParameters" as soon as we agree on this name.

Thumbs up from me.


More information about the jigsaw-dev mailing list