RFR: 8163126 Wrong @modules in some of jdk/* tests

Weijun Wang weijun.wang at oracle.com
Wed Aug 17 00:30:53 UTC 2016

Hi Shura

I am looking at test/jdk/security/jarsigner/Spec.java.

IMHO, even on a Solaris, without the SunPKCS11 provider at runtime, this 
test should be able to find Signature and MessageDigest implementations 
from the SunRsaSign and SUN provider.

Is the new @modules dependency necessary? In fact, I am curious how you 
note this test. Does it fail with some special settings?


On 8/17/2016 1:17, Alexandre (Shura) Iline wrote:
> Hi.
> Please review fixes related to module dependencies in a few jdk tests:
> http://cr.openjdk.java.net/~shurailine/8163126/webrev.00/index.html
> The review contains a few cases where jdk.zipfs is added to the module list. This is happening because all TestNG tests which use compiler API require jdk.zipfs to be able to read the testng jar. This is unfortunate but there is no easy way around that.
> Shura

More information about the jigsaw-dev mailing list