RFR 8164800: Cross targeting Windows
sundararajan.athijegannathan at oracle.com
Mon Aug 29 12:00:13 UTC 2016
Fixing along with another fix ->
On 8/26/2016 9:56 PM, Remi Forax wrote:
> Hi Sundararajan,
> Also, in createArgs(), instead Collections.unmodifiableList(), you can use List.of().
> ----- Mail original -----
>> De: "Sundararajan Athijegannathan" <sundararajan.athijegannathan at oracle.com>
>> À: "Alan Bateman" <Alan.Bateman at oracle.com>, "jigsaw-dev" <jigsaw-dev at openjdk.java.net>
>> Envoyé: Vendredi 26 Août 2016 18:08:12
>> Objet: Re: RFR 8164800: Cross targeting Windows
>> Hmm.. I saw another RuntimeException in the same file for another issue..
>> I guess I'll have to deal with this change when doing another fix in
>> that file - I do have one for reading java.version from java.base
>> descriptor. I'll clean it up when doing that fix.
>> On 8/26/2016 9:37 PM, Alan Bateman wrote:
>>> On 26/08/2016 15:54, Sundararajan Athijegannathan wrote:
>>>> Fixed as suggested:
>>>> * Field name changed to targetOsName
>>>> * Throwing RuntimeException if os name can't be determined from
>>> This looks okay except for RuntimeException, should this be
>>> PlugException with an appropriate cause? Also for the message then it
>>> would be better to say that the TargetPlatform attribute is missing
>>> from the java.base module.
More information about the jigsaw-dev