Review Request JDK-8169925: Organize licenses by module in source, JMOD file, and run-time image
Magnus Ihse Bursie
magnus.ihse.bursie at oracle.com
Thu Dec 8 10:58:19 UTC 2016
* In CreateJmods.gmk, you remove the TODO about headers, but I don't see
a resolution to that issue here. If you have opened a bug report for
that instead, please let me know the bug ID.
* The definitions of JDK/JMOD_COPYRIGHT/LICENSE in Modules.gmk seems to
be only used in Copy-java.base.gmk. Please move them there.
* jdk/src/java.base/share/legal/asm.md seems to have messed up the
character set, it's copyright by "France TÃ©lÃ©com". Possibly this is a
webrev issue, but please make sure it's correct before pushing. (I have
just looked at a few license files at random, so maybe you should
double-check all of them to make sure there are no other character
* Overall, I'm a bit confused about the ".md" suffix on the license
files. This seem to indicate that the files are in markdown format. But
from what I can tell, they are just the same plain text licenses as
before. Several of them, contains text that will be interpreted as
markdown markup codes, but will probably result in hideous looks since
it's not intentionally markdown formatted.
It seems that the licenses have a header with properly formatted
markdown prepended to them. I strongly suggest that you at the very
least put the original license text in code blocks (``` .... ```).
Also, is this markdown supposed to be processed into another format? I
could find no trace of such processing in the code.
On 2016-12-07 22:28, Mandy Chung wrote:
> This proposes to organize license files by module in source, JMOD,
> and run-time image.
> A summary of the proposal:
> 1. Organize third party notices by module in the source as follows:
> The `legal` directory contains one file for each third party
> library in the module, for example,
> The proposed template for this file is described in  and JEP 201
> will be updated to reflect this proposed source layout.
> 2. Introduce a new LEGAL_NOTICES section in JMOD format. A new jmod
> option `—-legal-notices` is added to package legal notices in
> a JMOD file.
> 3. At jlink time, jlink will copy all legal notices from JMOD files
> to the `legal` directory in the run-time image. A plugin is
> added to de-duplicate the legal notices if the filename and the
> content matches that may reduce the image footprint.
> 4. THIRD_PARTY_README in the top-level directory of each repo is removed.
> Manual edit to this file, multiple copies is no longer needed.
> Webrev at:
>  https://bugs.openjdk.java.net/browse/JDK-8169925
More information about the jigsaw-dev