Review Request JDK-8169925: Organize licenses by module in source, JMOD file, and run-time image
mandy.chung at oracle.com
Thu Dec 8 16:55:02 UTC 2016
> On Dec 8, 2016, at 2:58 AM, Magnus Ihse Bursie <magnus.ihse.bursie at oracle.com> wrote:
> Hi Mandy,
> Some comments.
> * In CreateJmods.gmk, you remove the TODO about headers, but I don't see a resolution to that issue here. If you have opened a bug report for that instead, please let me know the bug ID.
A new JMOD section was introduced to handle header files and man pages in JDK-8167558.
I realized now that it was sent to jigsaw-dev only (sorry for missing build-dev).
> * The definitions of JDK/JMOD_COPYRIGHT/LICENSE in Modules.gmk seems to be only used in Copy-java.base.gmk. Please move them there.
> * jdk/src/java.base/share/legal/asm.md seems to have messed up the character set, it's copyright by "France TÃ©lÃ©com". Possibly this is a webrev issue, but please make sure it's correct before pushing. (I have just looked at a few license files at random, so maybe you should double-check all of them to make sure there are no other character encoding issues.)
Good catch. Will double check all of them.
> * Overall, I'm a bit confused about the ".md" suffix on the license files. This seem to indicate that the files are in markdown format. But from what I can tell, they are just the same plain text licenses as before. Several of them, contains text that will be interpreted as markdown markup codes, but will probably result in hideous looks since it's not intentionally markdown formatted.
> It seems that the licenses have a header with properly formatted markdown prepended to them. I strongly suggest that you at the very least put the original license text in code blocks (``` .... ```).
We will take another pass on these files. I agree that the original license text should be code blocks.
> Also, is this markdown supposed to be processed into another format? I could find no trace of such processing in the code.
Not in the images build.
This enables a user to run tools like pandoc to aggregate these files and generate a separate document for example one single HTML file seeing all third party licenses or other format.
More information about the jigsaw-dev