RFR: 8171400: Move checking of duplicate packages in the boot layer to link time

Claes Redestad claes.redestad at oracle.com
Mon Dec 19 13:12:52 UTC 2016

On 12/19/2016 01:49 PM, Alan Bateman wrote:
> This looks good, just two comments:
> 1. SystemModules.hasSplitPackages should be clearer if just said that 
> it returns true if the run time images does not contain any split 
> packages.

Ok,so something like this?

      * @return {@code false} if we can no split packages in the 
run-time image,
      *         {@code true} if there are or the image has not been checked.
> 2. In ModuleBootstrap.boot then you move this code to the if 
> needPostResolutionChecks) { ... } block. 

I think that'd break things, since we need a logical || here (what you 
suggest is an &&):

If we need to do post resolution checks (due to patching the boot layer 
or such) we must
check (asthe information in SystemModules is now stale), but if we don't 
need to do post
resolution check and there's a possibility for split packages in the 
image we still need
to check.



More information about the jigsaw-dev mailing list