Review Request: 8179025: Exclude deployment modules from FieldSetAccessibleTest.java and VerifyJimage.java
peter.levart at gmail.com
Sat Apr 22 08:22:38 UTC 2017
In order to make the FieldSetAccessibleTest more resilient to future
changes (i.e. adding / renaming modules), perhaps the modules to be
excluded in the check should be explicitly listed by their names?
Currently your rule, when negated, lists the following modules:
...which is not to much to put in a Set.of(....) instance.
There's no harm if future changes forget to add/change this set, but it
would be wrong if the rule you have now, inadvertently excludes some
future module that should be checked.
On 04/21/2017 10:53 PM, Mandy Chung wrote:
> These tests failed due to IAE when loading types from the deployment
> modules which are expected to be defined when running with javaws
> or plugin. This revises the tests to exclude these modules to
> remove the tests from the problem list. In the long term, we
> should look into some way not to link in these modules in the image.
> This patch also updates JdkQualifiedExportTest.java test to take out
> the exception for deployment modules to have qualified exports to
> upgradeable modules.
More information about the jigsaw-dev