[PATCH] JMC-4326 : "ItemHandlerPage" - Columns should exist even though there is no data

Marcus Hirt marcus.hirt at oracle.com
Mon Aug 27 16:01:37 UTC 2018

Ah, that thing is only used by the ItemHandlerPage. Should be okay. 
Will take a look in a bit.

Kind regards,

On 2018-08-27, 13:29, "jmc-dev on behalf of Marcus Hirt" <jmc-dev-bounces at openjdk.java.net on behalf of marcus.hirt at oracle.com> wrote:

    Hi Miro,
    I think there may be some unintended consequences (e.g. Event Browser behaviour) 
    with this solution. Let's chat a bit tonight.
    Kind regards,
    On 2018-08-27, 09:57, "jmc-dev on behalf of Miro Wengner" <jmc-dev-bounces at openjdk.java.net on behalf of miro.wengner at gmail.com> wrote:
        Hi Marcus and everyone,
          here is my patch.
        test scenario:
         1. mvn clean package, mvn verify -> SUCCESS
         2. I’ve created different reading and changed columns visibilities, page state has been persisted and displayed after starting JCM again.
        Kind Regards,
        diff -r c4c637714f61 application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/itemhandler/AttributeComponentConfiguration.java
        --- a/application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/itemhandler/AttributeComponentConfiguration.java	Tue Aug 21 20:36:23 2018 +0200
        +++ b/application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/itemhandler/AttributeComponentConfiguration.java	Sun Aug 26 23:09:22 2018 +0200
        @@ -79,7 +79,7 @@
         	private void forEachType(IItemCollection items) {
         		if (items != null) {
        -			ItemCollectionToolkit.stream(items).filter(IItemIterable::hasItems).map(IItemIterable::getType)
        +			ItemCollectionToolkit.stream(items).map(IItemIterable::getType)
         					.forEach(type -> {
         						allTypes.put(type.getIdentifier(), type);
         						for (IAttribute<?> a : type.getAttributes()) {
        diff -r c4c637714f61 application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/itemhandler/ItemHandlerPage.java
        --- a/application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/itemhandler/ItemHandlerPage.java	Tue Aug 21 20:36:23 2018 +0200
        +++ b/application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/itemhandler/ItemHandlerPage.java	Sun Aug 26 23:09:22 2018 +0200
        @@ -215,7 +215,7 @@
         		private final ItemListAndChart itemListAndChart;
         		private IRange<IQuantity> currentRange;
         		private IItemCollection filteredItems;
        -		AttributeComponentConfiguration acc;
        +		private AttributeComponentConfiguration acc;
         		private IItemCollection selectionItems;
         		private String[] topics;

More information about the jmc-dev mailing list