JMC-6122: Method profiling rule should show the hottest path

Marcus Hirt marcus.hirt at
Mon Nov 26 22:29:16 UTC 2018

Hi Josh,

1. Map.replace was introduced in JDK 8, and core is still compiled with JDK 7.

2. Just a nit - could the assignment of the fields for the
   MethodProfilingWindowResult please be in the order of the arguments?

Kind regards,

On 2018-11-26, 22:26, "jmc-dev on behalf of Joshua Matsuoka" <jmc-dev-bounces at on behalf of jmatsuok at> wrote:

    Forgot the patch:
    - Josh
    On Mon, Nov 26, 2018 at 4:24 PM Joshua Matsuoka <jmatsuok at> wrote:
    > Hi,
    > The following patch addresses JMC-6122 by changing the grouping aggregator
    > to instead group on stack trace so we can retrieve the hottest path
    > alongside the hottest method and display it in the rule results.
    > As for the comment on the bug [1], I think that belongs more in a separate
    > bug addressed by another patch.
    > Thoughts?
    > [1]

More information about the jmc-dev mailing list