JMC-6122: Method profiling rule should show the hottest path
marcus.hirt at oracle.com
Tue Nov 27 20:11:22 UTC 2018
Looks good! Perhaps a new paragraph before the “The most common stack trace was”?
From: Joshua Matsuoka <jmatsuok at redhat.com>
Date: Tuesday, 27 November 2018 at 20:32
To: Marcus Hirt <marcus.hirt at oracle.com>
Cc: <jmc-dev at openjdk.java.net>
Subject: Re: JMC-6122: Method profiling rule should show the hottest path
Thanks for the review! Here's an updated webrev
On Mon, Nov 26, 2018 at 5:31 PM Marcus Hirt <mailto:marcus.hirt at oracle.com> wrote:
1. Map.replace was introduced in JDK 8, and core is still compiled with JDK 7.
2. Just a nit - could the assignment of the fields for the
MethodProfilingWindowResult please be in the order of the arguments?
On 2018-11-26, 22:26, "jmc-dev on behalf of Joshua Matsuoka" <mailto:jmc-dev-bounces at openjdk.java.net on behalf of mailto:jmatsuok at redhat.com> wrote:
Forgot the patch: http://cr.openjdk.java.net/~jmatsuoka/JMC-6122/webrev.01/
On Mon, Nov 26, 2018 at 4:24 PM Joshua Matsuoka <mailto:jmatsuok at redhat.com> wrote:
> The following patch addresses JMC-6122 by changing the grouping aggregator
> to instead group on stack trace so we can retrieve the hottest path
> alongside the hottest method and display it in the rule results.
> As for the comment on the bug , I think that belongs more in a separate
> bug addressed by another patch.
More information about the jmc-dev