Fix name of JDK Flight Recorder feature
guru.hb at oracle.com
Fri Apr 12 17:36:03 UTC 2019
I Agree with you Marcus,
@Jie, Please file a JBS bug for the same and send out for the review.
> On 12-Apr-2019, at 7:38 PM, Marcus Hirt <marcus at hirt.se> wrote:
> Hi Jie,
> I think it makes sense. I have a vague memory that this may have been one of those things that made it easier to get closer to a JMC 7 release (though, not easy enough, it would seem). I believe it should be changed in the mainline repo, and that any vendors who want something different (including Oracle) should override.
> Guru, what do you say?
> Kind regards,
> -----Ursprungligt meddelande-----
> Från: jmc-dev <jmc-dev-bounces at openjdk.java.net> För Jie Kang
> Skickat: den 12 april 2019 16:00
> Till: jmc-dev at openjdk.java.net
> Ämne: RFR: Fix name of JDK Flight Recorder feature
> This patch, pasted below, changes the name of the feature from "Oracle JDK Flight Recorder" to "JDK Flight Recorder", matching it's description.
> I'm not sure if the inclusion of Oracle in the name is intentional.
> Does this fix make sense?
> diff --git a/application/org.openjdk.jmc.feature.flightrecorder/feature.properties
> --- a/application/org.openjdk.jmc.feature.flightrecorder/feature.properties
> +++ b/application/org.openjdk.jmc.feature.flightrecorder/feature.propert
> +++ ies
> @@ -30,7 +30,7 @@
> # WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY # WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> -name=Oracle JDK Flight Recorder
> +name=JDK Flight Recorder
> provider=Oracle Corporation
> copyright=Copyright \u00A9 2018, 2019, Oracle and/or its affiliates.
> All rights reserved.
> description=The JDK Flight Recorder feature contains all the JFR related plug-ins.
More information about the jmc-dev