Review request for JMC-6274: Adding Eclipse 2018-12 and 2019-03 target platforms.
jkang at redhat.com
Mon Apr 29 19:50:35 UTC 2019
I tried both new target platforms and it looks okay to me as well. The
patch file has a weird file path with the './' in front but I imagine
it will resolve itself when you commit.
--- old/./pom.xml 2019-04-28 01:26:32.861640100 +0200
+++ new/./pom.xml 2019-04-28 01:26:32.742624000 +0200
On Mon, Apr 29, 2019 at 6:40 AM Guru <guru.hb at oracle.com> wrote:
> +1, Tested on Mac OS X, Windows and Linux (Ubuntu).
> > On 29-Apr-2019, at 3:00 PM, Marcus Hirt <marcus at hirt.se> wrote:
> > Hi all,
> > Please review this fix to support new Eclipse platforms and switching to
> > 2019-03 by default. Also removing Oxygen.
> > Jira: https://bugs.openjdk.java.net/browse/JMC-6274
> > Webrev: http://cr.openjdk.java.net/~hirt/JMC-6274/webrev.3/
> > Kind regards,
> > Marcus
More information about the jmc-dev