Review request for JMC-6408: Cleanup of MBeanOperationsWrapper

Marcus Hirt marcus.hirt at
Wed Feb 13 14:26:23 UTC 2019

You're quite right! I'll fix the order in a follow up check-in and 
set you as reviewer, unless someone objects.

Kind regards,

On 2019-02-13, 15:20, "Langer, Christoph" <christoph.langer at> wrote:

    Hi Marcus,
    looks good to me. Nice cleanup.
    However, I'd suggest another order of arguments for MBeanOperationWrapper:: createOperations, like this:
    static Collection<IOperation> createOperations(MBeanServerConnection connection , ObjectName objectName, MBeanOperationInfo[] operations)
    this would match the order of arguments of the constructor of MBeanOperationWrapper.
    Best regards
    > -----Original Message-----
    > From: jmc-dev <jmc-dev-bounces at> On Behalf Of Marcus
    > Hirt
    > Sent: Mittwoch, 13. Februar 2019 10:10
    > To: jmc-dev at
    > Subject: Review request for JMC-6408: Cleanup of
    > MBeanOperationsWrapper
    > Hi all,
    > Please review this fix to clean up the MBeanOperationsWrapper a bit
    > (should not subclass ArrayList).
    > Jira:
    > Webrev:
    > Kind regards,
    > Marcus

More information about the jmc-dev mailing list