JMC-6367 - Improve Thread graph tooltip
christoph.langer at sap.com
Fri Feb 15 15:28:33 UTC 2019
I had a look at your change. As I'm quite new to JMC it was merely to learn something
However, I could verify that your fix works and improves things in the thread lanes. I also couldn't find obvious mistakes.
But as newbie and since I'm no reviewer here I have to defer the real review to the JMC experts.
> -----Original Message-----
> From: jmc-dev <jmc-dev-bounces at openjdk.java.net> On Behalf Of Alex
> Sent: Donnerstag, 14. Februar 2019 22:22
> To: jmc-dev at openjdk.java.net
> Subject: RFR: JMC-6367 - Improve Thread graph tooltip
> The following webrev  addresses issue JMC-6367 , in which the thread
> lane tooltips should display descriptive information (thread & lane names)
> pertaining to the highlighted lane.
> The information to be displayed in the tooltip had to be carried in the
> Span object which is passed to the ChartToolTipProvider. There was an
> unused String description argument in the QuantitySpanRenderer which fits
> this need, and allows for the passing of the tooltip title from the
> ThreadGraphLanes through the QuantitySpanRenderer to the
> QuantitySpanRendering. This change was also mirrored in the SpanRenderer.
> If the Span obj has a description when it hits the ChartToolTipProvider, a
> title will be appended to the tooltip.
> I've created an imgur album  to show some examples. Some images
> illustrate the before and after of this patch when viewing tooltips for a
> thread , and viewing a thread that corresponds to an active filter
> (e.g., Java Latencies lane) .
>  http://cr.openjdk.java.net/~aptmac/JMC-6367/webrev.00/
>  https://bugs.openjdk.java.net/browse/JMC-6367
>  https://imgur.com/a/TOuq1ez
>  https://imgur.com/ueAbwHz
>  https://imgur.com/OOqYZ4I
>  https://imgur.com/K7JCa66
>  https://imgur.com/mPe3ah3
More information about the jmc-dev