JMC-6313: Exit menu item alternates visibility in "File"dropdown menu
marcus.hirt at oracle.com
Thu Jan 10 18:25:29 UTC 2019
Looks good. Perhaps inline the recentText and recentId String
local variables in ApplicationActionBarAdvisor? Let me know if
you need help running the UI tests.
On 2019-01-10, 18:52, "jmc-dev on behalf of Alex Macdonald" <jmc-dev-bounces at openjdk.java.net on behalf of almacdon at redhat.com> wrote:
The following webrev  addresses issue JMC-6313 , in which the Exit
option in the menubar toggles visibility.
The culprit here is the recent files list, which is supplied by the
ReopenEditorMenu via Eclipse Platform UI . When added to a menu, the
ReopenEditorMenu has an interesting effect where subsequent menu items
alternate being included and being missing from the menu when the menu is
opened. I cloned the Platform UI repo to try and poke around, and I ran
into an issue where the subsequent menu items actually aren't added to the
menu every-other click. I recreated this behaviour on a simple RCP
application and opened a bug report on the Eclipse bugzilla .
For what it's worth, the Recent Files list should be added to it's own
submenu. Placing the list into it's own submenu is also a workaround
because we won't be adding an Exit action sequentially in the menu after
the Recent Files list. The included patch  adds a new submenu
"recentMenu" and adds a couple of separators to distinguish it from it's
neighbouring menu items.
I've included a couple of images of before  and after  this patch, as
well as a couple of gifs (before  & after ) that show the issue and
More information about the jmc-dev