SV: JMC-6313: Exit menu item alternates visibility in "File"dropdown menu
marcus at hirt.se
Thu Jan 10 20:02:59 UTC 2019
Från: jmc-dev <jmc-dev-bounces at openjdk.java.net> För Alex Macdonald
Skickat: den 10 januari 2019 20:11
Till: Marcus Hirt <marcus.hirt at oracle.com>
Kopia: jmc-dev at openjdk.java.net
Ämne: Re: JMC-6313: Exit menu item alternates visibility in "File"dropdown menu
On Thu, Jan 10, 2019 at 1:25 PM Marcus Hirt <marcus.hirt at oracle.com> wrote:
> Hi Alex,
> Looks good. Perhaps inline the recentText and recentId String local
> variables in ApplicationActionBarAdvisor? Let me know if you need help
> running the UI tests.
Sure that sounds good to me, I've updated it in a newer webrev @ http://cr.openjdk.java.net/~aptmac/JMC-6313/webrev.01/.
I've run the UI tests with this patch applied and it doesn't interfere with the tests or menu highlighting.
> On 2019-01-10, 18:52, "jmc-dev on behalf of Alex Macdonald" <
> jmc-dev-bounces at openjdk.java.net on behalf of almacdon at redhat.com> wrote:
> The following webrev  addresses issue JMC-6313 , in which
> the Exit
> option in the menubar toggles visibility.
> The culprit here is the recent files list, which is supplied by the
> ReopenEditorMenu via Eclipse Platform UI . When added to a menu, the
> ReopenEditorMenu has an interesting effect where subsequent menu items
> alternate being included and being missing from the menu when the
> menu is
> opened. I cloned the Platform UI repo to try and poke around, and I ran
> into an issue where the subsequent menu items actually aren't
> added to the
> menu every-other click. I recreated this behaviour on a simple RCP
> application and opened a bug report on the Eclipse bugzilla .
> For what it's worth, the Recent Files list should be added to it's own
> submenu. Placing the list into it's own submenu is also a workaround
> because we won't be adding an Exit action sequentially in the menu
> the Recent Files list. The included patch  adds a new submenu
> "recentMenu" and adds a couple of separators to distinguish it
> from it's
> neighbouring menu items.
> Images :
> I've included a couple of images of before  and after  this
> patch, as
> well as a couple of gifs (before  & after ) that show the
> issue and
> proposed solution.
>  http://cr.openjdk.java.net/~aptmac/JMC-6313/webrev.00/
>  https://bugs.openjdk.java.net/browse/JMC-6313
>  https://bugs.eclipse.org/bugs/show_bug.cgi?id=543269
>  https://imgur.com/a/pJkEoKQ
>  https://imgur.com/gnV5aFw
>  https://imgur.com/8S4L7wi
>  https://imgur.com/GlVZ0Ut
>  https://imgur.com/jh6lDoH
More information about the jmc-dev