RFR: JMC-6211: Restore Defaults button doesn't revert username and password in Preferences
neugens at redhat.com
Tue Mar 5 14:16:05 UTC 2019
On Mon, 2019-03-04 at 19:29 -0500, Elliott Baron wrote:
> Marcus has informed me off-list that the above copyright header
> is acceptable going forward.
> I do still need a review for the content of this fix. Would someone
> able to take a look?
The patch looks good to me, I would like to have the opinion of an
official reviewer however before you push it.
A question on the Manifest.
Are those changes in the Manifest really necessary? I take a yes
because the ui tests are in a different package that need internal
Associate Manager, Software Engineering
Red Hat GmbH <https://www.redhat.com>
9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898
More information about the jmc-dev