Review request for JMC-3338: Visualization of loaded libraries.
marcus.hirt at datadoghq.com
Mon May 27 18:07:15 UTC 2019
Yep, ran the auto-formatter with the JMC settings. Seems we have some
files which haven't been properly formatted. Will take a look at the
JdkFilters file when I get back to my computer in Switzerland. :)
On Mon, May 27, 2019 at 11:55 AM Henrik Dafgård <hdafgard at gmail.com> wrote:
> Hi Marcus,
> I think the proposed change looks good, even though there are a few
> formatting/whitespace changes in there as well. The JdkFilters file also
> seems to be included without any changes somehow?
> Henrik Dafgård
> On Sat, 25 May 2019 at 01:38, Marcus Hirt <marcus at hirt.se> wrote:
> > Hi all,
> > Please review this fix to add simple visualization of loaded native
> > libraries.
> > Also fixes some other annoyances:
> > . Environment variables should be sorted on key by default.
> > . System properties should be sorted on key by default.
> > . It should be okay to have a query with both attributes and aggregators to
> > fuel
> > the DistinctItemsPage.
> > . Some unused imports.
> > Jira: https://bugs.openjdk.java.net/browse/JMC-3338
> > Webrev: http://cr.openjdk.java.net/~hirt/JMC-3338/webrev.0/
> > Kind regards,
> > Marcus
More information about the jmc-dev