RFR: 6631: Updating version to 8.0.0
hirt at openjdk.org
Thu Nov 14 19:43:03 UTC 2019
On Thu, 14 Nov 2019 19:35:04 GMT, Marcus Hirt <hirt at openjdk.org> wrote:
> On Thu, 14 Nov 2019 19:14:27 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:
>> On Thu, 14 Nov 2019 13:54:24 GMT, Marcus Hirt <hirt at openjdk.org> wrote:
>>> This patch updates the version to 8.0.0.
>>> - ffd61fd7: Updating to 8.0.0
>>> - 837906dc: Updating to 8.0.0
>>> Changes: https://git.openjdk.java.net/jmc/pull/1/files
>>> Webrev: https://webrevs.openjdk.java.net/jmc/1/webrev.00
>>> Issue: https://bugs.openjdk.java.net/browse/JMC-6631
>>> Stats: 376 lines in 289 files changed: 0 ins; 0 del; 376 mod
>>> Patch: https://git.openjdk.java.net/jmc/pull/1.diff
>>> Fetch: git fetch https://git.openjdk.java.net/jmc pull/1/head:pull/1
>> Also, should these commits be folded into each other because they're working to accomplish the same goal? Or will they be squashed when merged?
>> application/org.openjdk.jmc.updatesite.ide/src/main/resources/update-site-instructions/index.html line 79:
>>> 78: <p>Fill in the following URL in the <b>Work with:</b> text field:</p>
>>> 79: <p><b>https://download.oracle.com/technology/products/missioncontrol/updatesites/openjdk/8.0.0/eclipse/</b></p>
>>> 80: <p>Press the return key.</p>
>> My terminal is showing new empty spaces on this line ..
>> It seems to be because there's a tab just before the `<p>`, but up until that point it's single spaces.
>> Changes requested by aptmac (Committer).
> Funny, the following line also had a tab. Given the standard indentation of the project, they should all be tabs, but they got to be spaced for now.
> We should add spotless...
@Gunde - okay if I integrate this, even though there will be a review missing on record (since you're not properly hooked up yet)?
More information about the jmc-dev