RFR: 6659: Remove 'Showing X of Y events...' table message when not applicable

Jessye Coleman-Shapiro github.com+29706926+jessyec-s at openjdk.java.net
Fri Jan 10 20:09:05 UTC 2020

On Fri, 10 Jan 2020 15:12:18 GMT, Jie Kang <jkang at openjdk.org> wrote:

>> This patch addresses the following issue: 
>> When a table made with an itemList has more rows than the set maximum that can be shown, it displays a message "Showing X of Y events..." in its last row. This message is not removed if a search is performed on the table that results in fewer then the maximum number of events being displayed. For example, this is seen in the Exceptions page in the Event Log table.
>> ![table-example](https://user-images.githubusercontent.com/29706926/72159945-6cf9c380-338b-11ea-9f32-0fd3a6654709.png)
>> This patch makes the 'Showing X of Y events...'  table message disappear when less than the maximum number of events that can be displayed populate a table.
> Could the change be made to the user of this class? ExtraRowTableViewer could be used elsewhere for showing any kind of extra message not necessarily related to x of y events; maybe some text they always want to show. Then applying this logic wouldn't make sense.

In https://github.com/openjdk/jmc/pull/28/commits/fec30fd19289b4b2446f242723a6e7e7ee2b98d4 I have modified this patch to be implemented in the users of the ExtraRowTableViewer class instead of the class itself. This is keep the functionality of the ExtraRowTableViewer class more general as @jiekang mentioned.


PR: https://git.openjdk.java.net/jmc/pull/28

More information about the jmc-dev mailing list