[Rev 04] RFR: 6549: Color flame chart based on package name

Marcus Hirt hirt at openjdk.java.net
Tue Jan 14 23:12:26 UTC 2020

On Tue, 14 Jan 2020 23:12:25 GMT, Miroslav Wengner <mwengner at openjdk.org> wrote:

>> implemented ticket : https://bugs.openjdk.java.net/browse/JMC-6549
>> additionally:
>> 1. fixed issue with displaying big data set in flameview
>> 2. improved display speed
>> comments:  cell coloring algorithm is based on packageName hash with defined depth to avoid collisions and guarantee same stripPackageName color.
>> conclusion: the flameview is always displayed
> The pull request has been updated with 1 additional commit.

application/org.openjdk.jmc.flightrecorder.flameview/src/main/resources/jsjmclibs/flameviewColoring.js line 42:

> 41:         if (packageSelectedColor === undefined) {
> 42:         	const packageMarkerSelected = getPackageMarker(packageNameStrip);
> 43:         	const packageNameStripHash = packageNameStrip.hashCode();

These lines are mixing space and tabs for indentation. The rest of the file is using spaces for indentation. I'd go with tabs throughout the file, since that is used for the rest of the project.


Marked as reviewed by hirt (Lead).

PR: https://git.openjdk.java.net/jmc/pull/29

More information about the jmc-dev mailing list