[Rev 01] RFR: 6670: Harmonize ~ Unclassifiable ~ across Flame View and Stacktrace View

Miroslav Wengner mwengner at openjdk.java.net
Mon Jan 20 21:31:59 UTC 2020

On Mon, 20 Jan 2020 13:03:48 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> The pull request has been updated with 1 additional commit.
> application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/tree/TraceTreeUtils.java line 56:
>> 55: 
>> 56: 		private static TraceNode getRootTraceNode(String rootName, Fork rootFork) {
>> 57: 			return new TraceNode(rootName == null ? DEFAULT_ROOT_NAME : rootName, rootFork.getItemsInFork(),
> Is this really necessary? The factory class doesn't add much in terms of abstraction over having a factory method, and it's not clear to me why the get by frame method belongs in there and not the rest of the utility methods. I'd revert these changes, or at least add the helper methods as private statics without the extra inner class.

agree, helper methods are fine.


PR: https://git.openjdk.java.net/jmc/pull/38

More information about the jmc-dev mailing list