[Rev 01] RFR: 6670: Harmonize ~ Unclassifiable ~ across Flame View and Stacktrace View

Miroslav Wengner mwengner at openjdk.java.net
Mon Jan 20 21:35:11 UTC 2020

On Mon, 20 Jan 2020 13:27:48 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> The pull request has been updated with 1 additional commit.
> application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/messages/internal/Messages.java line 526:
>> 525: 	public static String VMOperationPage_TIMELINE_SELECTION;
>> 526: 	public static String Flameview_UNCLASSIFIABLE_FRAME_DESC;
>> 527: 
> Since it's only the flame view that uses this description, it could be in FlameView (it really should be, if it is to be named FlameView something). If we want the description to be generally available, it should be somewhere else. If we want it to be available to rules etc, it probably should live somewhere in core, near to where the definition of the unclassifiable frame is, e.g. in flightrecorder. One possible solution, would e.g. be to add a public messages bundle in the stacktrace package.

thanks, corrected, I had the solution in stacktrace bundle before as we want to add similar tooltip to the stactrace view


PR: https://git.openjdk.java.net/jmc/pull/38

More information about the jmc-dev mailing list