RFR: 6531: Make the flame chart view render labels on windows
aptmac at openjdk.java.net
Mon Jan 27 16:29:39 UTC 2020
On Sat, 25 Jan 2020 17:16:51 GMT, Marcus Hirt <hirt at openjdk.org> wrote:
>> It doesn't feel right to me to maintain d3-flame-graph fork, as @thegreystone stated it's a bit scary.
>> I'd rather to stay with ECMA 6 due to the d3 library compatibility and its future development.
>> I'd propose the way @thegreystone has stated -> SWT update to use an alternative (newer) browser.
>> we are planning to do the search/highlighting of nodes inside the flameview. This feature uses d3-lib functionality. I don't know whether this patch will not force us to maintain also the fork of d3 itself.
> How hard would it be to make SWT use Edge as the default embedded browser and fall back to IE if not available?
> It doesn't feel right to me to maintain d3-flame-graph fork, as @thegreystone stated it's a bit scary.
As for "maintaining the fork", the next version up from the fork (v2.0.3) is incompatible with IE, so the fork is basically a one-shot fix that can't be updated. The interesting thing here is that we're using v2.0.3 (Sept 2018) , so if we had used just one release prior then the flame labels would have rendered in JMC Windows (without text) prior to the latest commits for colouring.
> I'd propose the way @thegreystone has stated -> SWT update to use an alternative (newer) browser.
Chromium support was initially slated for integration Q1 2017 , and the related patch looked to be on track to be posted by the end of 2019 , but it hasn't made it out yet. So when the patch does get posted, it'll need review, inclusion into SWT, and then shipped with a release .. we're looking at potentially quite a bit of time before this happens, but hopefully not.
I'm conflicted both ways, so I'll go based on the consensus here. I'm not sure how popular JMC is for Windows, or how many people are wanting (or trying) to use the flame view, but it doesn't sit right with me that the view doesn't display anything. Maybe it can print an error screen mentioning the incompatibility instead?
More information about the jmc-dev