RFR: 6682: Flamegraph gets cutoff when resized horizontally to increase the width

Miroslav Wengner mwengner at openjdk.java.net
Fri Jan 31 18:31:38 UTC 2020

On Fri, 31 Jan 2020 18:29:49 GMT, Miroslav Wengner <mwengner at openjdk.org> wrote:

>>> I've fixed it in my PR 6677 too, I didn't know about this ticket. There will be few minor conflicts on the javascript side.
>> Ah fair enough, I didn't realize it was also included in 6677. I had opened the ticket after searching JIRA and not finding an existing one.
>> Your PR fixes the increasing width issue, but when shrinking it still seems to keep excess whitespace to the right of the chart because the SVG doesn't resize to be smaller; the `svg width=100%` used in this PR would address that.
>> I can close this PR and make reference on the bug that it'll get closed by #43 .
> actually it was not, I've asked marcus whether I could include into this one, I didn't like the fact when you use splash or resize the window that the flameview stays. I've still used the magnitude 0.95. 
> I've also fixed this part 
> String jsFlameviewColoring = "src/main/js/flameviewColoring.js"; to work again like was intended 
> String jsFlameviewColoring = "flameviewColoring.js";
> This was caused by the classpath, somewhere it got lost because it was working before 
> I think I'd propose to close the ticket due to work done in 6677 and make a reference.

what do you think ?


PR: https://git.openjdk.java.net/jmc/pull/44

More information about the jmc-dev mailing list