Raw data output
aleksey.shipilev at oracle.com
Thu Jul 21 15:49:51 UTC 2016
On 07/15/2016 03:35 PM, Petr Stefan wrote:
> I've updated my patch according to your comments. Thanks.
Any news about OCA? This is the thing that blocks us from going forward
with this patch :)
The patch looks OK. I have a few comments though:
a) Utils.loopOver can be simplified;
b) There is no need to emit empty "rawDataHistogram". If some data is
not available, it's best to avoid printing out special values, like
c) The grouping is incorrect: it adds up histograms from different
iterations. This happens because the code reuses the old loop that
prints out *scalar* per each iteration. But in histogram case, you have
to wrap it up one more time.
Hopefully fixed all three here:
Can you look into it, and verify it still works as intended?
More information about the jmh-dev