Raw data output
ptr.stef at gmail.com
Thu Jul 21 16:35:07 UTC 2016
Dne 21.7.2016 v 17:49 Aleksey Shipilev napsal(a):
> Any news about OCA? This is the thing that blocks us from going forward
> with this patch :)
No, I haven't heard from them yet. I can send you scan of the signed
document, but I think before they approve it's not valid.
> b) There is no need to emit empty "rawDataHistogram". If some data is
> not available, it's best to avoid printing out special values, like
> empty array.
OK, I don't need it. My idea was to keep symetry, like empty
secondaryMetrics when you don't use any profiler. But you have a point,
better keep it simple :).
> c) The grouping is incorrect: it adds up histograms from different
> iterations. This happens because the code reuses the old loop that
> prints out *scalar* per each iteration. But in histogram case, you have
> to wrap it up one more time.
Now I got it, you're right. My mistake, sorry.
> Hopefully fixed all three here:
> Can you look into it, and verify it still works as intended?
Yes, from my point it's perfect. Thank you very much.
More information about the jmh-dev