<div dir="ltr">Thanks!</div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Oct 27, 2014 at 7:02 PM, Jonathan Gibbons <span dir="ltr"><<a href="mailto:jonathan.gibbons@oracle.com" target="_blank">jonathan.gibbons@oracle.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
  
    
  
  <div bgcolor="#FFFFFF" text="#000000">
    Hi Martin,<br>
    <br>
    Approved; I assume you'd like me to push for you, so will do.<br>
    <br>
    -- Jon<div><div class="h5"><br>
    <br>
    <div>On 10/27/2014 06:37 PM, Martin Buchholz
      wrote:<br>
    </div>
    <blockquote type="cite">
      <div dir="ltr">[oops + jtreg-use]
        <div><br>
          <div class="gmail_quote">---------- Forwarded message
            ----------<br>
            From: <b class="gmail_sendername">Martin Buchholz</b> <span dir="ltr"><<a href="mailto:martinrb@google.com" target="_blank">martinrb@google.com</a>></span><br>
            Date: Mon, Oct 27, 2014 at 6:36 PM<br>
            Subject: RFR: 7901073: jtreg makefiles should chmod a-w
            instead of chmod -w<br>
            To: Jonathan Gibbons <<a href="mailto:jonathan.gibbons@oracle.com" target="_blank">jonathan.gibbons@oracle.com</a>><br>
            <br>
            <br>
            <div dir="ltr"><span style="font-family:arial,sans-serif;font-size:13px">Hi
                Jonathan,</span>
              <div style="font-family:arial,sans-serif;font-size:13px"><br>
              </div>
              <div style="font-family:arial,sans-serif;font-size:13px">I'd
                like you to do a code review.</div>
              <div><br>
              </div>
              <div>
                <div># HG changeset patch</div>
                <div># User martin</div>
                <div># Date 1414460013 25200</div>
                <div>#      Mon Oct 27 18:33:33 2014 -0700</div>
                <div># Node ID dbe3c2c342327350ca3f3f078614ef5882b32c98</div>
                <div># Parent  880984c8c5a0869dd991cdbd087d6fee57279dcf</div>
                <div>7901073: jtreg makefiles should chmod a-w instead
                  of chmod -w</div>
                <div>Summary: s/chmod -w/chmod a-w/g</div>
                <div>Reviewed-By: jjg</div>
                <div><br>
                </div>
                <div>diff --git a/make/Rules.gmk b/make/Rules.gmk</div>
                <div>--- a/make/Rules.gmk</div>
                <div>+++ b/make/Rules.gmk</div>
                <div>@@ -71,13 +71,13 @@</div>
                <div> <span style="white-space:pre-wrap"> </span>$(MKDIR)
                  -p $(@D)</div>
                <div> <span style="white-space:pre-wrap"> </span>$(RM)
                  $@</div>
                <div> <span style="white-space:pre-wrap"> </span>$(CP)
                  $(@:$(JTREG_IMAGEDOCDIR)/%=$(SRCDOCDIR)/%) $@</div>
                <div>-<span style="white-space:pre-wrap"> </span>chmod
                  -w $@</div>
                <div>+<span style="white-space:pre-wrap"> </span>chmod
                  a-w $@</div>
                <div> </div>
                <div> $(JTREG_IMAGEDOCDIR)/%: $(SRCDOCDIR)/%</div>
                <div> <span style="white-space:pre-wrap"> </span>$(MKDIR)
                  -p $(@D)</div>
                <div> <span style="white-space:pre-wrap"> </span>$(RM)
                  $@</div>
                <div> <span style="white-space:pre-wrap"> </span>$(CP)
                  $(@:$(JTREG_IMAGEDOCDIR)/%=$(SRCDOCDIR)/%) $@</div>
                <div>-<span style="white-space:pre-wrap"> </span>chmod
                  -w $@</div>
                <div>+<span style="white-space:pre-wrap"> </span>chmod
                  a-w $@</div>
                <div> </div>
                <div> #---------------------------------------------------------------------</div>
                <div> </div>
                <div>@@ -112,7 +112,7 @@</div>
                <div> <span style="white-space:pre-wrap"> </span>  
                   `sh pkgsToFiles.sh $(CLASSDIR)
                  $($(@F:%.jar=PKGS.JAR.%))` \</div>
                <div> <span style="white-space:pre-wrap"> </span>  
                   $(patsubst $(CLASSDIR)/%,-C $(CLASSDIR) %,$(sort
                  $(FILES.JAR.$(@F:%.jar=%)))) \</div>
                <div> <span style="white-space:pre-wrap"> </span>  
                   $(JAR_EXTRAS)</div>
                <div>-<span style="white-space:pre-wrap"> </span>$(CHMOD)
                  -w $@</div>
                <div>+<span style="white-space:pre-wrap"> </span>$(CHMOD)
                  a-w $@</div>
                <div> </div>
                <div> #----------------------------------------------------------------------</div>
                <div> #</div>
                <div>diff --git a/make/jtdiff.gmk b/make/jtdiff.gmk</div>
                <div>--- a/make/jtdiff.gmk</div>
                <div>+++ b/make/jtdiff.gmk</div>
                <div>@@ -64,7 +64,7 @@</div>
                <div> <span style="white-space:pre-wrap"> </span>$(MKDIR)
                  -p $(@D)</div>
                <div> <span style="white-space:pre-wrap"> </span>$(RM)
                  $@</div>
                <div> <span style="white-space:pre-wrap"> </span>$(CP)
                  $<  $@</div>
                <div>-<span style="white-space:pre-wrap"> </span>$(CHMOD)
                  +x,-w $@</div>
                <div>+<span style="white-space:pre-wrap"> </span>$(CHMOD)
                  a+x,a-w $@</div>
                <div> </div>
                <div> TARGETS.ZIP.jtreg += \</div>
                <div> <span style="white-space:pre-wrap"> </span>$(JTREG_IMAGEDIR)/bin/jtdiff</div>
                <div>@@ -84,7 +84,7 @@</div>
                <div> <span style="white-space:pre-wrap"> </span>  echo
                  '#' ; \</div>
                <div> <span style="white-space:pre-wrap"> </span>) >
                  $(BUILDDIR)/jtdiff.warning.sed</div>
                <div> <span style="white-space:pre-wrap"> </span>$(SED)
                  -f $(BUILDDIR)/jtdiff.warning.sed $< > $@</div>
                <div>-<span style="white-space:pre-wrap"> </span>$(CHMOD)
                  +x,-w $@</div>
                <div>+<span style="white-space:pre-wrap"> </span>$(CHMOD)
                  a+x,a-w $@</div>
                <div> </div>
                <div> TARGETS.ZIP.jtreg += \</div>
                <div> <span style="white-space:pre-wrap"> </span>$(JTREG_IMAGEDIR)/linux/bin/jtdiff
                  \</div>
                <div>diff --git a/make/jtreg.gmk b/make/jtreg.gmk</div>
                <div>--- a/make/jtreg.gmk</div>
                <div>+++ b/make/jtreg.gmk</div>
                <div>@@ -368,7 +368,7 @@</div>
                <div> <span style="white-space:pre-wrap"> </span>$(MKDIR)
                  -p $(@D)</div>
                <div> <span style="white-space:pre-wrap"> </span>$(RM)
                  $@</div>
                <div> <span style="white-space:pre-wrap"> </span>$(CP)
                  $<  $@</div>
                <div>-<span style="white-space:pre-wrap"> </span>$(CHMOD)
                  +x,-w $@</div>
                <div>+<span style="white-space:pre-wrap"> </span>$(CHMOD)
                  a+x,a-w $@</div>
                <div> </div>
                <div> TARGETS.ZIP.jtreg += \</div>
                <div> <span style="white-space:pre-wrap"> </span>$(JTREG_IMAGEDIR)/bin/jtreg</div>
                <div>@@ -388,7 +388,7 @@</div>
                <div> <span style="white-space:pre-wrap"> </span>  echo
                  '#' ; \</div>
                <div> <span style="white-space:pre-wrap"> </span>) >
                  $(BUILDDIR)/jtreg.warning.sed</div>
                <div> <span style="white-space:pre-wrap"> </span>$(SED)
                  -f $(BUILDDIR)/jtreg.warning.sed $< > $@</div>
                <div>-<span style="white-space:pre-wrap"> </span>$(CHMOD)
                  +x,-w $@</div>
                <div>+<span style="white-space:pre-wrap"> </span>$(CHMOD)
                  a+x,a-w $@</div>
                <div> </div>
                <div> TARGETS.ZIP.jtreg += \</div>
                <div> <span style="white-space:pre-wrap"> </span>$(JTREG_IMAGEDIR)/linux/bin/jtreg
                  \</div>
              </div>
              <div><br>
              </div>
            </div>
          </div>
          <br>
        </div>
      </div>
    </blockquote>
    <br>
  </div></div></div>

</blockquote></div><br></div>