Code review request

Brian Goetz brian.goetz at
Mon Mar 4 07:55:41 PST 2013

>> All protected fields should not be protected but package visible.
>> Classes are package private so there is no need to use a modifier which
>> offer a wider visibility.
>> The same is true for constructors.
> I believe some of these may end up being public (TBD), in which case
> better to define member accessibility as if they were already public as
> it greatly simplifies the changes needed later.

That's exactly right.  These classes were intended to be public and 
hopefully will be some day.  Capturing what should be protected now is a 
lot easier than baking it back in later.

More information about the lambda-libs-spec-experts mailing list