Request for review: 7125657 [macosx] SpreadSheet demo has the broken display when clicking outside of the table
sergey.bylokhov at oracle.com
Tue Feb 14 04:53:07 PST 2012
14.02.2012 14:40, Anthony Petrov пишет:
> Hi Sergey,
> The code change itself looks fine. However, I have a couple questions:
> 1. Why was this paintPeer() call needed in the updateComponent() in
> the first place? I assume there was some reason, and I wonder whether
> we break something by removing it.
I don't know the primary reason, but I am sure that it doesn't called on
windows. Small testcase was attached to 8-mr in which behavior on
windows and unix are different. Note that Apple jdk6 works in the same
way as on windows.
> 2. Have you run (at least automatic) SQE/JCK component
painting-related tests to ensure there's no regressions introduced with
I haven't found any regression, but it doesn't mean that they aren't
> best regards,
> On 2/10/2012 1:20 AM, Sergey Bylokhov wrote:
>> Hi Everyone,
>> There is no reason to paint native part of the peer on Update event.
>> Note that we paint it in the XToolkit but most of the code(and this
>> demo) is working, because XPanel.paintPeer is noop.
>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7125657
>> Webrev can be found at:
Best regards, Sergey.
More information about the macosx-port-dev