Request for review: 7125657 [macosx] SpreadSheet demo has the broken display when clicking outside of the table
anthony.petrov at oracle.com
Tue Feb 14 04:56:29 PST 2012
On 2/14/2012 4:53 PM, Sergey Bylokhov wrote:
> 14.02.2012 14:40, Anthony Petrov пишет:
>> Hi Sergey,
>> The code change itself looks fine. However, I have a couple questions:
>> 1. Why was this paintPeer() call needed in the updateComponent() in
>> the first place? I assume there was some reason, and I wonder whether
>> we break something by removing it.
> I don't know the primary reason, but I am sure that it doesn't called on
> windows. Small testcase was attached to 8-mr in which behavior on
> windows and unix are different. Note that Apple jdk6 works in the same
> way as on windows.
> > 2. Have you run (at least automatic) SQE/JCK component
> painting-related tests to ensure there's no regressions introduced with
> this fix?
> I haven't found any regression, but it doesn't mean that they aren't
Thanks for the clarification. The fix looks OK to me.
>> best regards,
>> On 2/10/2012 1:20 AM, Sergey Bylokhov wrote:
>>> Hi Everyone,
>>> There is no reason to paint native part of the peer on Update event.
>>> Note that we paint it in the XToolkit but most of the code(and this
>>> demo) is working, because XPanel.paintPeer is noop.
>>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7125657
>>> Webrev can be found at:
More information about the macosx-port-dev