Request for review: 7144063: [macosx] Swing JMenu mnemonic doesn't work; hint misleading; cross symbol typed
scott.kovatch at oracle.com
Tue Feb 14 08:24:27 PST 2012
I recall writing that code originally a very long time ago, so my memory is hazy. Maybe Mike can do a 'cvs blame' on the old Apple codebase for the original reason I added that check.
I seem to recall it was for handling some of the less common input methods like Bulgarian or Cherokee - Nation that can trigger multiple characters on a single keystroke.
This is not to say your change is wrong, but it would be good to check the test case for why I added that check in the first place.
On Feb 14, 2012, at 7:50 AM, Alexander Zuev wrote:
> please review my fix for bug 7144063: [macosx] Swing JMenu mnemonic doesn't work; hint misleading; cross symbol typed
> Bug description: http://bugs.sun.com/view_bug.do?bug_id=7144063
> Webrev for proposed change: http://cr.openjdk.java.net/~kizune/7144063/webrev.00/
> The idea of the fix is to call the java handler for creation of InputMethod events
> for all the complex symbols instead of just for symbols with length of 3 bytes or more.
> With best regards,
> Alexander Zuev
More information about the macosx-port-dev