Request for review: 7144063: [macosx] Swing JMenu mnemonic doesn't work; hint misleading; cross symbol typed
alexander.zuev at oracle.com
Tue Feb 14 10:55:50 PST 2012
i found quite opposite - i were unable to enter all the Cherokee symbols
without my fix - some of them just not typed - and i'm able to type in
all the Cherokee - Nation/Cherokee - QWERTY glyphs exactly as i do in
the native application (TextEdit for example).
With best regards,
On 2/14/12 19:24, Scott Kovatch wrote:
> I recall writing that code originally a very long time ago, so my memory is hazy. Maybe Mike can do a 'cvs blame' on the old Apple codebase for the original reason I added that check.
> I seem to recall it was for handling some of the less common input methods like Bulgarian or Cherokee - Nation that can trigger multiple characters on a single keystroke.
> This is not to say your change is wrong, but it would be good to check the test case for why I added that check in the first place.
> -- Scott
> On Feb 14, 2012, at 7:50 AM, Alexander Zuev wrote:
>> please review my fix for bug 7144063: [macosx] Swing JMenu mnemonic doesn't work; hint misleading; cross symbol typed
>> Bug description: http://bugs.sun.com/view_bug.do?bug_id=7144063
>> Webrev for proposed change: http://cr.openjdk.java.net/~kizune/7144063/webrev.00/
>> The idea of the fix is to call the java handler for creation of InputMethod events
>> for all the complex symbols instead of just for symbols with length of 3 bytes or more.
>> With best regards,
>> Alexander Zuev
More information about the macosx-port-dev