Code Review Request: 7144274: [macosx] Default IPv6 multicast interface is not being set when calling MulticastSocket.joinGroup()

Kurchi Hazra kurchi.subhra.hazra at
Tue Feb 14 11:12:44 PST 2012

Updated webrev:

- Kurchi

On 2/14/2012 12:58 AM, Chris Hegarty wrote:
> Trivially, I don't think getDefaultScopeID needs it's implementation 
> to be ifdef'ed with MACOSX, at all. Then won't need the 'else return 0;'.
> It is just a general utility method to get the value of the 
> defaultIndex field of NetworkInterace. Yes, the value will be 0 on all 
> platforms other than Mac, but equally getDefaultScopeID will not be 
> called on any platform, other than Mac.
> -Chris.
> On 02/14/12 07:46 AM, Alan Bateman wrote:
>> On 13/02/2012 22:03, Kurchi Hazra wrote:
>>> Hi,
>>> Before joining multicast groups with IPv6 addresses on Mac OS, the
>>> network interface to be used should also be set correctly. This
>>> change enables using a default network interface on Mac OS X if no
>>> interface
>>> has been specified.
>>> Bug:
>>> Webrev:
>> Kurchi - I think you should include an #else return 0; in
>> getDefaultScopeID as otherwise I will guess you will get warnings when
>> this code is compiled on other platforms.
>> -Alan.


More information about the macosx-port-dev mailing list