Review request for 7128699: Make jdk and jre installation directories consistent on Mac OS X
scott.kovatch at oracle.com
Thu Feb 23 15:45:55 PST 2012
On Feb 23, 2012, at 1:54 PM, Mike Swingler wrote:
> On Feb 21, 2012, at 10:18 PM, Scott Kovatch wrote:
>> Please review the following fix:
>> The bug description is here:
>> The name of the created JDK and JRE bundle isn't including the JDK_UPDATE_VERSION. Use JDK_VERSION instead of THIS_JDK_VERSION so it gets picked up. Also, prefix the bundle with 'jdk' or 'ire' as needed to match other platforms. We maintain the bundle extension so it is recognized as a bundle on Mac OS X, but if filename extensions are turned off in the finder you can't tell a JDK from a JRE.
> If this hasn't been reviewed already by someone at Oracle, this looks like a good change, and will facilitate the ability to install these bundles side-by-side.
> Is THIS_JDK_VERSION used anywhere else? Could it be removed at the definition point?
Yes, it's used in jdk/make/common/Release.gmk to generate the 'release' file at the top of the distribution tree. It looks like it would be a bad thing to get rid of it.
This will have to go in as a critical 7u4 fix at this point, so I'll start that process.
More information about the macosx-port-dev