<AWT Dev> [7u4] Review request for 7147435: closed/java/awt/Toolkit/Headless/WrappedToolkitTest/WrappedToolkitTest.sh failed since 7u4b11
anthony.petrov at oracle.com
Tue Feb 28 02:47:02 PST 2012
I believe you've clicked the wrong link. My webrev at
contains changes to the awt_LoadLibrary.c file only. I have provided a
link to the webrev for 7124511 as a reference only, and put it in the
very end of my message to avoid confusion. Please follow the link in the
beginning of the message to review the fix. Thanks.
On 2/28/2012 2:01 AM, Artem Ananiev wrote:
> Hi, Anthony,
> I have an impression your webrev is prepared against an outdated version
> of code. For example, the change in java_props_md.c:431 is already in
> the workspace...
> Other comments:
> 1. HeadlessGraphicsEnvironment is in the sun.java2d package, not sun.awt
> 2. Changes to awt_LoadLibrary.c look fine as all the defaults are set in
> 3. GraphicsEnvironment.java also looks fine.
> On 2/27/2012 6:30 AM, Anthony Petrov wrote:
>> Please review a fix for
>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7147435 at:
>> This bug is a regression of 7124511 fixed for the JDK Mac Port . With
>> that fix the code setting the awt.toolkit and java.awt.graphicsenv
>> system properties has been removed from JNI_OnLoad() of libawt.so.
>> Actually, the test WrappedToolkitTest.sh relies on the ability to
>> override the default toolkit by means of setting the AWT_TOOLKIT
>> environment variable, and because of the removal the test has failed.
>> With the fix for 7147435 I'm restoring the removed parts. In order to
>> not break the fix for 7124511, I'm setting the system properties only if
>> the XToolkit has been requested explicitly.
>>  http://cr.openjdk.java.net/~anthony/x-5-forceHeadless.0/
>> best regards,
More information about the macosx-port-dev