RFR: 7113349 JDK8 port to macosx
michael.x.mcmahon at oracle.com
Thu Mar 1 07:07:21 PST 2012
Thanks for all the comments. Take it all have been acted on as suggested
except as indicated below:
On 27/02/12 23:47, David Holmes wrote:
> Hi Michael,
> Partial review of jdk changes. Sorry but it is too large to go through
> everything in detail.
> General meta comment: When this stuff went into 7u my biggest
> complaint was that it introduced a mass of new platform-specific stuff
> in places that weren't otherwise platform specific. That still seems
> to be the case. I was really hoping/expecting that these issues could
> be resolved before it was merged with JDK8 otherwise they will never
> be fixed. Eg jdk/make/common/Rules.gmk,
> jdk/make/common/shared/Defs-java.gmk. It seems to me that many of the
> specializations could be placed into the platform-specific gmk file(s)
> instead of polluting the shared ones. In some case though (eg
> Makefiles where we have to change SUBDIR) it indicates we need a
> better way to specialize things.
> Ditto for the Java code. I really hate to see platform specific
> changes added to Java code that previously was platform independent.
Thanks for all the comments. I think we have removed the most egregious
to the shared code. In most cases what remains are changes in files that
have (other) platform specific changes.
For files that have introduced mac specific changes where there weren't
any platform specific
code before then I think I agree with Alan, it might be better for the
component teams to
deal with this in their own time. We certainly have some work to do in
for that. Also, build changes may end up being moot anyway, given the up
coming build-infra work.
I'm making the other changes per your specific comments.
John Rose wrote:
> Here's a quick comment (or bug report) on one makefile, make/tools/freetypecheck/Makefile.
> Is this only a problem for people who make builds with OPENJDK=true?
Thanks for pointing that out. It only affected OPENJDK builds. All the
testing I had done so far was just on closed builds. I'm taking the patch
mentioned by Henri as it keeps the original build options on other
Latest webrev at:
More information about the macosx-port-dev