Request for review 7151821: [macosx] Mnemonic doesn't work in JTabbedPane

Anthony Petrov anthony.petrov at
Tue Mar 13 08:01:39 PDT 2012

Hi Alexander,

How about doing something more generic, like the following:

chars = [ev chars];
if (chars is empty) {
    chars = [ev charsIgnoreMods];

? What might go wrong with such approach? In this case we'll also see 
chars=='e' for Option+e. Would that be a bug, or would it be actually 
something that we'd like to see?

best regards,

On 3/13/2012 5:13 PM, Alexander Scherbatiy wrote:
> Please review a fix for 7151821.
> webrev:
> This is a fix for regression after switching using [event 
> charactersIgnoringModifiers] string to [event characters] during the 
> MACOSX_PORT-568 issue fixing:
> The characters string is null during Ctrl+Alt+Char mnemonic pressing.
> According to the NSEvent charactersIgnoringModifiers doc:
> This method returns the non-modifier key character pressed for dead 
> keys, such as Option-e.
> For example, Option-e (no shift key) returns an “e" for this method, 
> whereas the characters method returns an empty string.
> The fix uses the charactersIgnoringModifiers string for the keychar when 
> the Ctrl+Alt mnemonic key combination is pressed.
> Thanks,
> Alexandr.

More information about the macosx-port-dev mailing list