Request for review 7151821: [macosx] Mnemonic doesn't work in JTabbedPane
leonid.romanov at oracle.com
Tue Mar 13 08:35:08 PDT 2012
Hit "Send" too early. Basically, what you are describing in 7151821 is exactly the way JDK 6 works. So, what is wrong with it? Does it break anything?
On 13.03.2012, at 19:24, Leonid Romanov wrote:
> What is the test case for this issue? What Control+alt+char is supposed to do?
> On 13.03.2012, at 17:13, Alexander Scherbatiy wrote:
>> Please review a fix for 7151821.
>> webrev: http://cr.openjdk.java.net/~alexsch/7151821/webrev.00/
>> This is a fix for regression after switching using [event charactersIgnoringModifiers] string to [event characters] during the MACOSX_PORT-568 issue fixing:
>> The characters string is null during Ctrl+Alt+Char mnemonic pressing.
>> According to the NSEvent charactersIgnoringModifiers doc:
>> This method returns the non-modifier key character pressed for dead keys, such as Option-e.
>> For example, Option-e (no shift key) returns an “e" for this method, whereas the characters method returns an empty string.
>> The fix uses the charactersIgnoringModifiers string for the keychar when the Ctrl+Alt mnemonic key combination is pressed.
More information about the macosx-port-dev