[7u4] Review request for CR 7124286: [macosx] Option modifier should work like AltGr as in Apple jdk 6

Mike Swingler swingler at apple.com
Wed Mar 14 08:32:10 PDT 2012

On Mar 14, 2012, at 6:39 AM, Leonid Romanov wrote:

> Hi,
> Please review a fix for for http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7124286
> webrev: http://cr.openjdk.java.net/~leonidr/7124286/webrev.00/
> Since this fix modifies shared code, I tried to keep as much of original code as possible. Also, isPrintableCharacterModifiersMask() might be not the best name possible: the reason I used it is because I couldn't come with better name.

Really the only alternative would be opposite: isCommandInvocationModifiersMask(), which may be more accurate as to what you are testing...seems like a tossup to me though.

The general idea seems fine, and I like how the Mac behavior difference can be handled by a simple override, but others may have more specific critiques.

Mike Swingler
Apple Inc.

More information about the macosx-port-dev mailing list