[7u4] Review request for 7145768 - [macosx] Regression: failure in b11 of ModalDialogInFocusEventTest

Artem Ananiev artem.ananiev at oracle.com
Mon Mar 19 05:47:26 PDT 2012

Hi, Anton,

I don't see anything wrong with the fix. Please, bear in mind I'm not an 
expert in AWT focus code, though :)



On 3/12/2012 6:04 PM, Anton V. Tarasov wrote:
> Hello,
> Please review a fix for 7145768.
> webrev: http://cr.openjdk.java.net/~ant/7145768/webrev.0/webrev
> The fix addresses two focus issues:
> 1. A window's native focus state should be inspected when
> requestFocusInWindow() call chain is evaluated. This is to avoid
> requesting focus to a window when it's not allowed for an unfocused window.
> 2. Requesting focus to a window being shown should go through the
> requestWindowFocus() method,
> which manages all necessary native focus requests (requests focus to an
> owner when a simple window is shown). The changeFocusedWindow() method
> is called after native focused window is already set
> and it just processes this fact on java level.
> Thanks,
> Anton.

More information about the macosx-port-dev mailing list