[7u4] Review request for 7154480: [macosx] Not all popup menu items are visible

Anthony Petrov anthony.petrov at oracle.com
Fri Mar 23 11:14:32 PDT 2012

Hi Leonid,

The code changes look good to me. I'm approving the fix given the 
emergency of the issue.

However, I think that a more elegant solution for this bug would be to 
-setLevel: for always-on-top Java windows of the type POPUP to a value 
that pushes the windows above the dock. This way we wouldn't need an 
overridable method in the SunToolkit class. Could you file a CR to 
investigate this possibility in a future release please?

best regards,

On 3/23/2012 9:48 PM, Leonid Romanov wrote:
> Hi,
> Release team has decided that we'd better fix 7154480 for 7u4 because of its high impact on users, so please review a fix for it. The fix prevents popups from overlapping with the Dock/menu bar on OS X, keeping the old behavior for other platforms.
> Bug:  http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7154480
> Webrev: http://cr.openjdk.java.net/~leonidr/7154480/webrev.00/
> Thanks,
> Leonid.

More information about the macosx-port-dev mailing list