Request for review 7156191 [macosx] Can't type into applet demos in Pivot
Anton V. Tarasov
anton.tarasov at oracle.com
Tue Mar 27 06:28:52 PDT 2012
On 26.03.2012 19:55, Dmitry Cherepanov wrote:
> Hi Artem,
> Artem Ananiev wrote:
>> The fix looks fine. CEmbeddedFrame.updateOverlayWindowActiveState() JavaDoc may be corrected,
>> though: does it still post a WINDOW_ACTIVATED event?
> I think that the comment is still valid. The code generates a WINDOW_ACTIVATED event when the
> embedded frame becomes the active window.
The comment is formally valid indeed, but for me it doesn't convey any meaningful info. The method
initiates window activation or deactivation which means it will notify KFMPeer that the focused
window has changed and will post WINDOW_GAINED_FOCUS or WINDOW_LOST_FOCUS. When the event gets
dispatched by the shared KFM (asynchronously and deeply further) it will eventually generate
WINDOW_ACTIVATED or WINDOW_DEACTIVATED.
The comment mentions only one event from that chain of actions. Is it so important to document in
this context? May be we should remove the comment at all?
>> On 3/26/2012 6:37 PM, Dmitry Cherepanov wrote:
>>> Here's a fix for 7156191 ([macosx] Can't type into applet demos in Pivot)
>>> The current implementation of focus event handlers in CEmbeddedFrame
>>> dispatches focus events directly to the embedded frame. The fix changes
>>> the implementation and now it calls peer.notifyActivation() like it's
>>> done in standalone mode.
More information about the macosx-port-dev