Patch review: fix infinite loop in anonymousClassLoader.checkHostClass
John.Rose at Sun.COM
Fri Apr 18 14:13:39 PDT 2008
Good fix, Remi. Thanks!
Folks, I'm looking forward to a long collaboration with lots of MLVM
patches. Let's use the message format described here:
At this early point, since sub-projects like anonk are tracked under
omnibus bugs, you do not need to include a bug number with your
patch. Mention the sub-project identifier (anonk) instead of the bug
Thus, a formal patch submission for Remi's bug would have this
Subject: [PATCH] anonk: fix infinite loop in
For simple fixes, the formal patch submission and the review request
be accomplished in the same Email. For complex fixes or works in
progress, you might want to ask for review first:
Subject: Patch review: anonk: fix infinite loop in
If the patch is large, consider submitting it in the form of a link
to a webrev, like this:
At present, you are on your own finding web hosting for the webrev.
Sorry! I believe this is in the works behind a bunch of other
A version of the webrev script is available at:
There is much more information about being an OpenJDK developer here:
Finally, if you haven't signed the Sun Contributor Agreement, you'll
need to do that before the project can incorporate your work.
On Apr 18, 2008, at 9:47 AM, Rémi Forax wrote:
> There is a potential infite loop in the current code of the
> In checkHostClass, the caller and the callee need to be normalized
> to their top level classes,
> but outer is not updated in the loop.
> The attachment is a test case to reproduce the bug.
> I propose the following patch:
More information about the mlvm-dev