review request (XL): 6839872: remove implementation inheritance from JSR 292 APIs
john.r.rose at oracle.com
Thu Mar 3 11:55:20 PST 2011
Thanks for reading over the code, Remi! Will fix. -- John
On Mar 3, 2011, at 2:44 AM, Rémi Forax wrote:
> Hi John & Christian,
> I've noticed several gotchas.
> in CallSite:
> - makesite you create a InvokeDynamicBootstrapError but forget to throw it.
> - TRANSITIONAL_BEFORE_PFD is not final
> - maybeReBox can be split in two methods to avoid to double-check if a value is an instanceof Integer.
> in MethodHandle:
> 1 typo, line 451: by by
> Also I'm not a big fan of using an import static for something else than cos() and sin().
> It takes me times to find getNameString().
> in MethodHandleStatics:
> You should split getNameString in 3 overloaded methods:
> getNameString(MethodHandle, MethodType)
> getNameString(MethodHandle, MethodHandle)
> The last twos should delegate to getNameString(MethodHandle, MethodType)
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the mlvm-dev