<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div><div>[cc-ing mlvm-dev in reply, because of general interest]</div><div><br></div><div>On Apr 24, 2008, at 5:06 AM, Thamaraiselvan Poomalai wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">Hello John,<br><br>I have successfully compiled hotsopt and jdk with mlvm patches from <a href="http://hg.openjdk.java.net/mlvm/mlvm">http://hg.openjdk.java.net/mlvm/mlvm</a>.</blockquote><div><br></div>Thanks for giving it a spin, Selvan.</div><div><br><blockquote type="cite">1) Though i did full jdk build after applying patches, java/dyn package is skipped by build process (i couldn't trace compiled java/dyn packages under sources/build/openjdk_full_debug/classes/java). Could we also include necessary make files for java/dyn package in our patch?</blockquote><div><br></div><div>Yes, that's coming.</div><br><blockquote type="cite">2) Here are the things i did to make build successful,<br><br>After executing below commands from README.txt,<br> $ mkdir davinci<br> ... ... ...<br> ... ... ...<br> $ sh patches/make/each-patch-repo.sh hg qselect --reapply $guards<br> <br>i executed below command to push patch changes to source repository,<br><br>$ sh patches/make/each-patch-repo.sh hg qpush -a</blockquote><div><br></div><div>Hmm. I thought --reapply would do this; We'll add that to the instructions.</div><br><blockquote type="cite">Output of above command was,<br>===========================<br>[root@iwsg OpenJDK]# sh patches/make/each-patch-repo.sh hg qpush -a<br> + (cd sources/hotspot; hg qpush -a)<br>applying anonk.patch<br>skipping callcc.patch - guarded by '-testable'<br>Now at: anonk.patch<br>+ (cd sources/jdk; hg qpush -a)<br>applying anonk.patch<br>skipping callcc.patch - guarded by '-testable'<br> Now at: anonk.patch<br>===========================<br><br>It skipped callcc.patch for hotspot and jdk. When i try to do build with callcc.patch skipped, i got following error,</blockquote><div><br></div><div>Yes, callcc.patch is very rough right now. Lukas Stadler has a much more complete version which I think he'll be releasing soon.</div><br><blockquote type="cite">===========================<br>/share/software/OpenJDK/sources/hotspot/src/share/vm/classfile/classFileParser.cpp: In member function 'constantPoolHandle ClassFileParser::parse_constant_pool(Thread*)':<br> /share/software/OpenJDK/sources/hotspot/src/share/vm/classfile/classFileParser.cpp:316: error: 'find_well_known_klass' is not a member of 'SystemDictionary'<br>/share/software/OpenJDK/sources/hotspot/src/share/vm/classfile/classFileParser.cpp: In member function 'void ClassFileParser::patch_constant_pool(constantPoolHandle, int, Handle, Thread*)':<br> /share/software/OpenJDK/sources/hotspot/src/share/vm/classfile/classFileParser.cpp:434: error: 'is_instance' is not a member of 'java_lang_Class'<br>make[5]: *** [classFileParser.o] Error 1<br>make[5]: Leaving directory `/share/software/OpenJDK/sources/build/openjdk_full_debug/hotspot/outputdir/linux_i486_compiler2/jvmg'<br> make[4]: *** [the_vm] Error 2<br>===========================</blockquote><div><br></div><div>Thanks. It looks like callcc.patch has a tweak that anonk.patch should have instead. The well-known-klass fix is not yet in the baseline (I'm working on it today).</div><br><blockquote type="cite">I removed "#-testable" from sources/jdk/.hg/patches/series, sources/hotspot/.hg/patches/series and re-applied callcc.patch.After removing "#-testable", series file looks as below<br> <br>anonk.patch #-/anonk #+jdk7-b25<br>#meth.patch #-/meth #+jdk7-b25 #-buildable<br>#indy.patch #-/indy #+jdk7-b25 #-buildable<br>#inti.patch #-/inti #+jdk7-b25 #-buildable<br> callcc.patch #-/callcc #+jdk7-b25</blockquote><div><br></div><div>To get callcc in, it would be better to qselect buildable (not buildable + testable). The series file is supposed to represent the rough development status of each patch.</div><br><blockquote type="cite">After applying anonk.patch and callcc.patch to sources, hotspot and full jdk build was successful. <br><br>My login name for wiki (<a href="http://wikis.sun.com/display/mlvm/Home">http://wikis.sun.com/display/mlvm/Home</a>) is <a href="mailto:p.thamarai@gmail.com">p.thamarai@gmail.com</a></blockquote><div><br></div>OK, I added you (user id selvan) as an author to <a href="http://wikis.sun.com/display/mlvm">http://wikis.sun.com/display/mlvm</a> .</div><div>Please feel free to record useful information on the wiki.</div><div><br></div><div>-- John</div></body></html>